Rulefit mojo: features() contains response column

h2oai / h2o-3

H2O is an Open Source, Distributed, Fast & Scalable Machine Learning Platform: Deep Learning, Gradient Boosting (GBM) & XGBoost, Random Forest, Generalized Linear Modeling (GLM with Elastic Net), K-Means, PCA, Generalized Additive Models (GAM), RuleFit, Support Vector Machine (SVM), Stacked Ensembles, Automatic Machine Learning (AutoML), etc.

http://h2o.ai

Apache License 2.0

6.91k stars 2k forks source link

Rulefit mojo: features() contains response column #7327

Closed exalate-issue-sync[bot] closed 1 year ago

exalate-issue-sync[bot] commented 1 year ago

When rfit mojo gets trained, features contains response column.

This is caused by RuleFitMojoModel#nfeatures() what was needed for handling zero weights block in RuleFitMojoModel#score0(). But since PUBDEV-8249 got clarified as not a bug, this is not needed and it also causes this bug.

exalate-issue-sync[bot] commented 1 year ago

Michal Kurka commented: FIY [~accountid:5d1185d4f46aa30c271c7cc6] this one should skip release notes - it is a fix of an unreleased feature

h2o-ops-ro commented 1 year ago

JIRA Issue Details

Jira Issue: PUBDEV-8329 Assignee: Zuzana Olajcová Reporter: Marek Novotny State: Resolved Fix Version: N/A Attachments: N/A Development PRs: Available

h2o-ops-ro commented 1 year ago

Linked PRs from JIRA

https://github.com/h2oai/h2o-3/pull/5763