search

h2oai / h2o-3

H2O is an Open Source, Distributed, Fast & Scalable Machine Learning Platform: Deep Learning, Gradient Boosting (GBM) & XGBoost, Random Forest, Generalized Linear Modeling (GLM with Elastic Net), K-Means, PCA, Generalized Additive Models (GAM), RuleFit, Support Vector Machine (SVM), Stacked Ensembles, Automatic Machine Learning (AutoML), etc.
http://h2o.ai
Apache License 2.0
6.88k stars 1.99k forks source link

SharedTree can produce splits that are out of range #7402

Open exalate-issue-sync[bot] opened 1 year ago

exalate-issue-sync[bot] commented 1 year ago

For histogram types != uniform adaptive, this code

      if( h._isInt > 0 ) lo = h._step==1 ? lo-1 : Math.floor(lo);
      if( h._isInt > 0 ) hi = h._step==1 ? hi   : Math.ceil (hi);

from https://github.com/h2oai/h2o-3/blob/master/h2o-algos/src/main/java/hex/tree/DTree.java#L203

can produce split points that are out of range if the column is integer.

Eg. binary column (0, 1 values) can split on split point = -0.05.

h2o-ops commented 1 year ago

JIRA Issue Details

Jira Issue: PUBDEV-8251 Assignee: New H2O Bugs Reporter: Michal Kurka State: Open Fix Version: N/A Attachments: N/A Development PRs: N/A