search

h2oai / h2o4gpu

H2Oai GPU Edition
Apache License 2.0
460 stars 95 forks source link

SVD power method not converging well #422

Open pseudotensor opened 6 years ago

pseudotensor commented 6 years ago

https://github.com/h2oai/h2o4gpu/commit/7a7424f7253ea650989b9b5174e8597801d95222#diff-1a13759f63589530199630e07535c1a7R89

navdeep-G commented 6 years ago

Will close this in favor of #416

navdeep-G commented 6 years ago

Issue here: https://github.com/h2oai/h2o4gpu/blob/master/tests_open/svd/test_tsvd_wrapper.py#L60 Components are not matching, but everything else is.

sh1ng commented 5 years ago

@navdeep-G why such tolerance has been taken in np.allclose?