h2oai / h2o4gpu

H2Oai GPU Edition
Apache License 2.0
460 stars 95 forks source link

Fix #175, #204 #722

Closed sh1ng closed 5 years ago

sh1ng commented 5 years ago

The goal of this PR is to fix memory leak with minimal changes. What was done:

Please let me know if I forget to fix/add something else(extra tests, documentation, etc)

We need more robust and clear logic when dealing with memory e.g. (not in this PR):

pseudotensor commented 5 years ago

Concern is segfaults are not solved. Please try demos in examples/py/demos

sh1ng commented 5 years ago

Unable to reproduce segfaults(tested also all demos). Found out that memory still not completely released even after del model, but it's not growing. I'm going to continue in separate PR.