Closed sh1ng closed 5 years ago
Concern is segfaults are not solved. Please try demos in examples/py/demos
Unable to reproduce segfaults(tested also all demos).
Found out that memory still not completely released even after del model
, but it's not growing. I'm going to continue in separate PR.
The goal of this PR is to fix memory leak with minimal changes. What was done:
WrappedPointer
is deleted by GC)Please let me know if I forget to fix/add something else(extra tests, documentation, etc)
We need more robust and clear logic when dealing with memory e.g. (not in this PR):
T** data
instead ofT* data
to detect that referenced pointer is freedCUDACHECK
everywhere, it's difficult and time consuming sometimes to point an exact place in the code