h2oai / h2o4gpu

H2Oai GPU Edition
Apache License 2.0
460 stars 95 forks source link

Fix NOTE's found in CRAN #873

Closed navdeep-G closed 3 years ago

navdeep-G commented 3 years ago

https://cran.r-project.org/web/checks/check_results_h2o4gpu.html

ledell commented 3 years ago

@navdeep-G I pushed the changes I suggested above. Can you re-submit to R-Hub to check that the LazyData edit is ok?

navdeep-G commented 3 years ago

@ledell Everything seems fine now:


R version 3.4.4 (2018-03-15) -- "Someone to Lean On"
Copyright (C) 2018 The R Foundation for Statistical Computing
Platform: x86_64-pc-linux-gnu (64-bit)

R is free software and comes with ABSOLUTELY NO WARRANTY.
You are welcome to redistribute it under certain conditions.
Type 'license()' or 'licence()' for distribution details.

  Natural language support but running in an English locale

R is a collaborative project with many contributors.
Type 'contributors()' for more information and
'citation()' on how to cite R or R packages in publications.

Type 'demo()' for some demos, 'help()' for on-line help, or
'help.start()' for an HTML browser interface to help.
Type 'q()' to quit R.

> library(devtools)
Loading required package: usethis
lib> library(rhub)

Attaching package: ‘rhub’

The following object is masked from ‘package:devtools’:

    check

> devtools::check_rhub("h2o4gpu/")
Building the package will delete...
  '/home/navdeep/h2o4gpu/src/interface_r/h2o4gpu/inst/doc'
Are you sure?

1: Yes
2: No

Selection: 1
✔  checking for file ‘/home/navdeep/h2o4gpu/src/interface_r/h2o4gpu/DESCRIPTION’ (505ms)
─  preparing ‘h2o4gpu’:
✔  checking DESCRIPTION meta-information ...
─  installing the package to build vignettes
✔  creating vignettes (2.5s)
─  checking for LF line-endings in source and make files and shell scripts
─  checking for empty or unneeded directories
─  building ‘h2o4gpu_0.3.3.tar.gz’

─  Uploading package
─  Preparing build, see status at
   https://builder.r-hub.io/status/h2o4gpu_0.3.3.tar.gz-2c56ec3ae12b468f9e76a44803ba667d
   https://builder.r-hub.io/status/h2o4gpu_0.3.3.tar.gz-872d4639e9394466b481141822f26744
   https://builder.r-hub.io/status/h2o4gpu_0.3.3.tar.gz-7dade76224864505946b6fb46ebb14f8
─  Build started
─  Creating new user
─  Downloading and unpacking package file
─  Querying package dependencies
─  Installing package dependencies
─  Running R CMD check
   setting _R_CHECK_FORCE_SUGGESTS_ to false
   setting R_COMPILE_AND_INSTALL_PACKAGES to never
   setting _R_CHECK_THINGS_IN_CHECK_DIR_ to false
   setting R_REMOTES_STANDALONE to true
   setting R_REMOTES_NO_ERRORS_FROM_WARNINGS to true
   setting _R_CHECK_FORCE_SUGGESTS_ to true
   setting _R_CHECK_CRAN_INCOMING_USE_ASPELL_ to true
   'getOption("repos")' replaces Bioconductor standard repositories, see
   replacement repositories:
       CRAN: https://cloud.r-project.org

   '?repositories' for details
─  using log directory 'C:/Users/USERMBGbAtjJzR/h2o4gpu.Rcheck'
─  using R Under development (unstable) (2021-04-15 r80175) (1.3s)
─  using platform: x86_64-w64-mingw32 (64-bit)
─  using session charset: ISO8859-1
─  using option '--as-cran'
✔  checking for file 'h2o4gpu/DESCRIPTION' (644ms)
─  checking extension type ... Package
─  this is package 'h2o4gpu' version '0.3.3'
─  package encoding: UTF-8
N  checking CRAN incoming feasibility (1.3s)
   Maintainer: 'Navdeep Gill <navdeep@h2o.ai>'

   New maintainer:
     Navdeep Gill <navdeep@h2o.ai>
   Old maintainer(s):
     Yuan Tang <terrytangyuan@gmail.com>
✔  checking package namespace information
✔  checking package dependencies (1.3s)
✔  checking if this is a source package
✔  checking if there is a namespace
✔  checking for executable files
✔  checking for hidden files and directories (1.3s)
✔  checking for portable file names
✔  checking serialization versions
✔  checking whether package 'h2o4gpu' can be installed
✔  checking installed package size (640ms)
✔  checking package directory
✔  checking for future file timestamps
✔  checking 'build' directory
✔  checking DESCRIPTION meta-information (1.3s)
✔  checking top-level files
✔  checking for left-over files
✔  checking index information
✔  checking package subdirectories (640ms)
✔  checking R files for non-ASCII characters
✔  checking R files for syntax errors
✔  checking whether the package can be loaded
✔  checking whether the package can be loaded with stated dependencies (1.3s)
✔  checking whether the package can be unloaded cleanly
✔  checking whether the namespace can be loaded with stated dependencies
✔  checking whether the namespace can be unloaded cleanly
✔  checking loading without being on the library search path (641ms)
✔  checking use of S3 registration
✔  checking dependencies in R code
✔  checking S3 generic/method consistency
✔  checking replacement functions (1.3s)
✔  checking foreign function calls
✔  checking R code for possible problems
✔  checking Rd files
✔  checking Rd metadata (712ms)
✔  checking Rd line widths
✔  checking Rd cross-references
✔  checking for missing documentation entries
✔  checking for code/documentation mismatches (1.3s)
✔  checking Rd \usage sections
✔  checking Rd contents
✔  checking for unstated dependencies in examples
✔  checking installed files from 'inst/doc' (645ms)
✔  checking files in 'vignettes'
✔  checking examples
✔  checking for unstated dependencies in 'tests'
─  checking tests (1.3s)
✔  Running 'testthat.R'
✔  checking for unstated dependencies in vignettes
✔  checking package vignettes in 'inst/doc' (649ms)
✔  checking re-building of vignette outputs
✔  checking PDF version of manual (29.4s)
✔  checking for non-standard things in the check directory
✔  checking for detritus in the temp directory

─  Done with R CMD check
─  Cleaning up files and user

── h2o4gpu 0.3.3: NOTE

  Build ID:   h2o4gpu_0.3.3.tar.gz-2c56ec3ae12b468f9e76a44803ba667d
  Platform:   Windows Server 2008 R2 SP1, R-devel, 32/64 bit
  Submitted:  4m 2.3s ago
  Build time: 3m 59s

❯ checking CRAN incoming feasibility ... NOTE
  Maintainer: 'Navdeep Gill <navdeep@h2o.ai>'

  New maintainer:
    Navdeep Gill <navdeep@h2o.ai>
  Old maintainer(s):
    Yuan Tang <terrytangyuan@gmail.com>

0 errors ✔ | 0 warnings ✔ | 1 note ✖

── h2o4gpu 0.3.3: IN-PROGRESS

  Build ID:   h2o4gpu_0.3.3.tar.gz-872d4639e9394466b481141822f26744
  Platform:   Ubuntu Linux 20.04.1 LTS, R-release, GCC
  Submitted:  4m 2.4s ago

── h2o4gpu 0.3.3: IN-PROGRESS

  Build ID:   h2o4gpu_0.3.3.tar.gz-7dade76224864505946b6fb46ebb14f8
  Platform:   Fedora Linux, R-devel, clang, gfortran
  Submitted:  4m 2.5s ago

> 
Build ID:h2o4gpu_0.3.3.tar.gz-872d4639e9394466b481141822f26744Platform:Ubuntu Linux 20.04.1 LTS, R-release, GCCSubmitted:6 minutes 45.3 seconds agoBuild time:6 minutes 43.8 seconds Build ID: h2o4gpu_0.3.3.tar.gz-872d4639e9394466b481141822f26744 Platform: Ubuntu Linux 20.04.1 LTS, R-release, GCC Submitted: 6 minutes 45.3 seconds ago Build time: 6 minutes 43.8 seconds
Build ID: h2o4gpu_0.3.3.tar.gz-872d4639e9394466b481141822f26744
Platform: Ubuntu Linux 20.04.1 LTS, R-release, GCC
Submitted: 6 minutes 45.3 seconds ago
Build time: 6 minutes 43.8 seconds

NOTES:* checking CRAN incoming feasibility ... NOTE Maintainer: ‘Navdeep Gill navdeep@h2o.ai’ New maintainer: Navdeep Gill navdeep@h2o.ai Old maintainer(s): Yuan Tang terrytangyuan@gmail.com


* Fedora:
Build ID:h2o4gpu_0.3.3.tar.gz-7dade76224864505946b6fb46ebb14f8Platform:Fedora Linux, R-devel, clang, gfortranSubmitted:7 minutes 13 seconds agoBuild time:7 minutes 11.5 seconds Build ID: h2o4gpu_0.3.3.tar.gz-7dade76224864505946b6fb46ebb14f8 Platform: Fedora Linux, R-devel, clang, gfortran Submitted: 7 minutes 13 seconds ago Build time: 7 minutes 11.5 seconds
Build ID: h2o4gpu_0.3.3.tar.gz-7dade76224864505946b6fb46ebb14f8
Platform: Fedora Linux, R-devel, clang, gfortran
Submitted: 7 minutes 13 seconds ago
Build time: 7 minutes 11.5 seconds

NOTES:* checking CRAN incoming feasibility ... NOTE Maintainer: ‘Navdeep Gill navdeep@h2o.ai’ New maintainer: Navdeep Gill navdeep@h2o.ai Old maintainer(s): Yuan Tang terrytangyuan@gmail.com


* Ubuntu:

TBD ...