h2oai / nitro

Create apps 10x quicker, without Javascript/HTML/CSS.
https://nitro.h2o.ai
Apache License 2.0
200 stars 14 forks source link

make setup fails on OSX #112

Closed fazpu closed 1 year ago

fazpu commented 1 year ago

Describe the bug https://github.com/h2oai/nitro/blob/598856e7b24dc159ec1eb8a4e424bf9e377f5031/CONTRIBUTING.md

make setup fails with:

  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [8 lines of output]
      Traceback (most recent call last):
        File "<string>", line 2, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "/Users/jiripuc/code/github/nitro/py/web/setup.py", line 30, in <module>
          version=get_version("h2o_nitro_web"),
        File "/Users/jiripuc/code/github/nitro/py/web/setup.py", line 12, in get_version
          init_py = open(path, "r", encoding="utf8").read()
      FileNotFoundError: [Errno 2] No such file or directory: 'h2o_nitro_web/version.py'
      [end of output]

The source of the problem is that make version gives:

make: `version' is up to date.

Environment (please complete the following information):

Additional context Add any other context about the problem here.

lo5 commented 1 year ago

@fazpu Thanks for reporting.

Looks like make sees /VERSION on OSX (case-insensitive).

On Linux:

$ make version
echo "__version__ = \"0.19.0\"" > py/pkg/h2o_nitro/version.py
echo "__version__ = \"0.19.0\"" > py/web/h2o_nitro_web/version.py

$ make VERSION
make: Nothing to be done for 'VERSION'.

I'll rename the make task.