h2oai / sparkling-water

Sparkling Water provides H2O functionality inside Spark cluster
https://docs.h2o.ai/sparkling-water/3.3/latest-stable/doc/index.html
Apache License 2.0
961 stars 361 forks source link

Local creation of Sparkling Water does not work anymore. #4927

Closed exalate-issue-sync[bot] closed 1 year ago

exalate-issue-sync[bot] commented 1 year ago

Before:

./gradlew clean build -x check
./make-dist.sh

was working to produce a local distribution package.

Right now it is failing on:

building file list ... rsync: link_stat "/Users/michal/Devel/projects/h2o/repos/sparkling-water/doc/build/site/." failed: No such file or directory (2)
done
created directory /Users/michal/Devel/projects/h2o/repos/sparkling-water/dist/build//doc
exalate-issue-sync[bot] commented 1 year ago

Jakub Hava commented: 2 options:

./gradlew clean build -x check ./gradlew site // generate the doc ./make-dist.sh

I prefer the second option as I think it's good to have documentation build separated for example for development purposes.

exalate-issue-sync[bot] commented 1 year ago

Michal Malohlava commented: what about having prepareDist or dist in gradlew. it will do build/site/scaladoc and it is finalized by a message to call make-dist.sh

The best case would be to have everything in gradlew

exalate-issue-sync[bot] commented 1 year ago

Jakub Hava commented: Agree! I just wanted to minimize the change, but this is absolutely a good step. Will work on this! Thanks!

exalate-issue-sync[bot] commented 1 year ago

Jakub Hava commented: ./gradlew dist now builds java/scala classes, javadoc, scaladoc, site and finishes by running make-dist.sh

DinukaH2O commented 1 year ago

JIRA Issue Migration Info

Jira Issue: SW-825 Assignee: Jakub Hava Reporter: Michal Malohlava State: Resolved Fix Version: 2.1.28 Attachments: N/A Development PRs: Available

Linked PRs from JIRA

https://github.com/h2oai/sparkling-water/pull/708

hasithjp commented 1 year ago

JIRA Issue Migration Info Cont'd

Jira Issue Created Date: 2018-04-30T13:56:43.213-0700