search

h2oai / sparkling-water

Sparkling Water provides H2O functionality inside Spark cluster
https://docs.h2o.ai/sparkling-water/3.3/latest-stable/doc/index.html
Apache License 2.0
968 stars 360 forks source link

Fixes #5738 #5740

Open hutch3232 opened 1 month ago

hutch3232 commented 1 month ago

Avoid requiring setuptools at runtime. Using importlib from the python standard library.

importlib.resources.path is actually deprecated: https://docs.python.org/3.12/library/importlib.resources.html#importlib.resources.path however, the replacement was new in python 3.9. Can switch to the new files function once support is dropped for python < 3.9.

hutch3232 commented 1 month ago

As of yesterday, python 3.8 is now end of life. If this project wants to be consistent with that, I could revise this PR to drop support for 3.8 and update this code to use the new function instead of the deprecated version. Would that be preferred?

wendycwong commented 1 month ago

We currently support python 3.6 and above.

hutch3232 commented 1 month ago

Sounds good, I'll leave it as is unless you suggest otherwise