h2oai / wave-apps

Sample AI Apps built with H2O Wave.
MIT License
143 stars 52 forks source link

Make setup instructions more inclusive #108

Open mturoci opened 1 year ago

mturoci commented 1 year ago

Current setup instructions require make to be installed. However, this can be a showstopper for windows users which lacks make installation by default.

We could either:

cc @mtanco @geomodular for discussion

geomodular commented 1 year ago

Would be great to find a typical user for this kind of use case and discuss it. From my perspective, I suggest to:

Rewrite the instructions to plain python commands.

I'd refrain from using Python as a build/setup tool. I think it's not necessary here.

denzuko commented 9 months ago

Yes, make is rather ubiquitous in POSIX and absent (by design)™ in Microsoft. But what I have found over the years is that PyInvoke is the closes thing to an agnostic replacement for Make. Mind you that means one has to rewrite thier makefiles into a tasks.py file but it is a near one to one since each @task decorated function's context parameter has a method called .run() which calls a shell just like make does while the dependency of tasks is just a list passed to the pre parameter to the @task decorator.

That said, if one still wants to use Makefiles on non-POSIX systems then there is Cygwin, MSYS, Docker, and the newer WSL2. which ports a POSIX environment into Win64 systems.

My vote is for PyInvoke seeing how the ecosystem is mainly python based and developers can grok python easier than batch files or Makefiles.