search

h2oai / wave-apps

Sample AI Apps built with H2O Wave.
MIT License
143 stars 52 forks source link

Updated known errors #112

Closed ayushtiwari110 closed 1 year ago

ayushtiwari110 commented 1 year ago

I tested the app on windows and mac. I was not able to arrange Linux so didn't test it on Linux.

As discussed, I have updated the errors which I saw on windows and which were known to me. The instructions are already nice so I didn't feel they need to be simplified or so... Kindly have a look, and if everything seems good, accept this PR and mark it as Hactoberfest accepted.

ayushtiwari110 commented 1 year ago

hello @mturoci , kindly have a look and accept this PR

ayushtiwari110 commented 1 year ago

I have commited the changes suggested by you. kindly check, and if everything's fine mark as hacktoberfest-accepted

ayushtiwari110 commented 1 year ago

@mturoci thanks for highlighting those points. I have updated the changes as requested. Kindly see.

ayushtiwari110 commented 1 year ago

@mturoci kindly check

ayushtiwari110 commented 1 year ago

Thanks! Nice time working on this , please do add hacktoberfest accepted tag also

mturoci commented 1 year ago

Merging is enough to count towards your Hacktoberfest submissions, no worries :)

ayushtiwari110 commented 1 year ago

Okay, thanks! Learned new things while working on this :)