search

h2oai / wave-apps

Sample AI Apps built with H2O Wave.
MIT License
143 stars 52 forks source link

Update docker development Windows install instructions #115

Open mturoci opened 1 year ago

mturoci commented 1 year ago

Update the Windows install instructions in https://github.com/h2oai/wave-apps/tree/main/docker-development, based on the UNIX ones.

InfasMohammed commented 1 year ago

Here are the updated instructions for installing Docker on Windows:

Check the system requirements: Docker Desktop for Windows requires 64-bit Windows 10 Pro, Enterprise, or Education version 1809 or later, with Hyper-V enabled. You also need at least 4GB of RAM. #

Download Docker Desktop for Windows: Go to the Docker website and download the Docker Desktop for Windows installer.

Run the installer: Double-click the installer to start the installation process. If prompted, allow the installer to make changes to your system.

Configure Docker: After the installation is complete, Docker Desktop launches automatically. You can configure Docker by clicking the Docker icon in the system tray and selecting "Settings". Here, you can adjust settings such as the amount of memory and CPU Docker is allowed to use.

Verify installation: Open a command prompt or PowerShell window and run the command docker version to verify that Docker is installed and running correctly.

Start using Docker: You can start using Docker by running Docker commands in a command prompt or PowerShell window. You can also use a graphical user interface such as Kitematic to manage your Docker containers.

That's it! With these steps, you should now have Docker up and running on your Windows machine.

mturoci commented 1 year ago

Thanks @InfasMohammed! Can you make a PR with these instructions in the Windows section of this readme?

mturoci commented 1 year ago

Also please verify, if

git clone https://github.com/h2oai/wave-apps.git
cd wave-apps/docker-development
docker build . -t wave_local_dev
docker run -p 10101:10101 -v $(pwd)/src:/app/src wave_local_dev:latest

work on windows as well and successfully allow you to go to http://localhost:10101 in your browser.

devarsh10 commented 11 months ago

Also please verify, if

git clone https://github.com/h2oai/wave-apps.git
cd wave-apps/docker-development
docker build . -t wave_local_dev
docker run -p 10101:10101 -v $(pwd)/src:/app/src wave_local_dev:latest

work on windows as well and successfully allow you to go to http://localhost:10101 in your browser.

Hey @mturoci, I verified it on Windows and I got the "Hi, Hello World!" message. Is it expected?

Screenshot: image

Regards, Devarsh Shah.

mturoci commented 11 months ago

Yes @devarsh10, that's right. You can update the README accordingly - the instructions are the same for all OSes.

devarsh10 commented 11 months ago

Okay @mturoci, I just have to add the Docker installation steps right?

mturoci commented 11 months ago

No. That's covered in https://www.docker.com/. The goal is to make it clear how to run the dockerized app - https://github.com/h2oai/wave-apps/tree/main/docker-development. The wording used may be a bit confusing so we can change installation to set up maybe.

harshjais369 commented 10 months ago

Thanks @InfasMohammed! Can you make a PR with these instructions in the Windows section of this readme?

Could you assign me this issue under hacktoberfest?

mturoci commented 10 months ago

@harshjais369 you can go ahead. We do not assign issues.

denzuko commented 9 months ago

One simpler method is to append docker-development/README.md:20 to include / Windows since docker for desktop on win64 systems does have the same CLI tools that MacOS and Linux has, this also includes WSL.

denzuko commented 9 months ago

I have both implemented in https://github.com/h2oai/wave-apps/pull/123