h2oai / wave

Realtime Web Apps and Dashboards for Python and R
https://wave.h2o.ai
Apache License 2.0
3.9k stars 327 forks source link

fix: Add disabled choices support for dialog dropdown #1959 #1961

Closed marek-mihok closed 1 year ago

marek-mihok commented 1 year ago

This PR brings 2 fixes:

https://user-images.githubusercontent.com/23740173/235901449-8622e2ef-d917-438d-b88b-3c729b87049e.mov

https://github.com/h2oai/wave/assets/23740173/932e8557-5f56-44a2-be00-dce9323df2e1

Closes #1959 Closes #1963

marek-mihok commented 1 year ago

What is submitted if I specify the disabled choice as checked initially and then do my selection for other (non-disabled) choices? Is the initial disabled choice part of the final submission or not?

@mturoci it is but for dialog dropdown only.

https://user-images.githubusercontent.com/23740173/237037407-0a3202b2-bcd3-481e-b8f1-6266369ecb16.mov

For base dropdown it is only when doing selections manually but it is not when using Select all/Deselect all. Since this issue relates to dialog dropdown only, I've created a separate issue for the base dropdown last week.

mturoci commented 1 year ago

it is but for dialog dropdown only.

Both dialog and regular dropdown must always be in sync so let's fix them both in this PR.

marek-mihok commented 1 year ago

@mturoci, both of them are fixed now.