kajanan1212
commented
1 year ago When I investigated more on ui.picker, I found another thing. I tried to update the values of the ui.picker by using the trigger of that component. On that time, It works fine at the normal case. It doesn't show the selected values multiple time within the box when a user selects the already selected values from the suggestions list.
But if we tries the same thing in a side panel then it doesn't work like the normal case.
-
It shows the selected values multiple time within the box when a user selects the already selected values from the suggestions list. [See the later part of the 1st video which has been provided below.]
-
If we select a different value between a same value (eg: XYX) and try to unpick the 1st occurrence of that same value in the raw then it behaves weirdly. [See the 2nd video which has been provided below.]
Anyway, showing the already selected values in the suggestions list is an unnecessary thing in both the cases.
https://github.com/h2oai/wave/assets/89178049/1e5c3d73-180f-4378-8f51-4d4097b55d74
https://github.com/h2oai/wave/assets/89178049/7c9ccdf6-e3fa-4464-bb8e-520fce8d89a5
Steps To Reproduce
from h2o_wave import main, app, Q, ui
choices=[
ui.choice(name='spam', label='Spam'),
ui.choice(name='eggs', label='Eggs'),
ui.choice(name='ham', label='Ham'),
ui.choice(name='cheese', label='Cheese'),
ui.choice(name='beans', label='Beans'),
ui.choice(name='toast', label='Toast'),
]
@app('/')
async def serve(q: Q):
main_values = q.args.main_picker if q.args.main_picker else []
side_panel_values = q.args.side_panel_picker if q.args.side_panel_picker else []
q.page['card_1'] = ui.form_card(
box='1 1 4 3',
items=[
ui.picker(
name='main_picker',
label='Tags:',
choices=choices,
values=main_values,
trigger=True,
),
]
)
q.page['card_2'] = ui.form_card(
box='5 1 4 3',
items=[
ui.button(
name='show_side_panel',
label='Open side panel',
primary=True,
),
]
)
if not q.client.initialized:
q.page['meta'] = ui.meta_card(box='')
q.client.initialized = True
else:
if q.args.show_side_panel:
q.page['meta'].side_panel = ui.side_panel(
title='Side Panel',
blocking=True,
items=[
ui.picker(
name='side_panel_picker',
label='Tags:',
choices=choices,
values=side_panel_values,
trigger=True,
),
ui.button(
name='close_side_panel',
label='Close',
primary=True,
),
]
)
elif q.args.close_side_panel:
q.page['meta'].side_panel = None
await q.page.save()
Wave SDK Version, OS
Wave SDK: 0.24.2 , OS: MacOs
Actual behavior
https://github.com/h2oai/wave/assets/89178049/6b887789-3500-4d6e-8e3d-16512b97cae9
When using a
ui.picker, we can select a choice more than one time. Here, after the selection of a value, the suggestions list doesn't show the selected value when typing that selected value within the box. That is fine. But the selected value still visible and selectable in the suggestions list when clicking on the box.Expected behavior
When using a
ui.picker, we won't be able to select a choice more than one time. After the selection of a value, when clicking on the box,So far, It works well when typing the selected value within the box.
Steps To Reproduce