fix: Perform numerical sort in map buffer if possible.

h2oai / wave

Realtime Web Apps and Dashboards for Python and R

https://wave.h2o.ai

Apache License 2.0

3.9k stars 327 forks source link

fix: Perform numerical sort in map buffer if possible. #1987

Closed mturoci closed 1 year ago

mturoci commented 1 year ago

This PR makes sure that map buffer entries are sorted in numerical order (if keys are valid numbers), defaulting to regular string sort.

Needs discussion

@lo5 this is a possible breaking change although I don't think there are many people relying on string sort order. There are ways around making this non-breaking, but not sure if worth the hassle + IMO this should be the right behavior. Wdyt?

mturoci commented 1 year ago

Closing in favor of a better proposal.