search

h2oai / wave

Realtime Web Apps and Dashboards for Python and R
https://wave.h2o.ai
Apache License 2.0
3.9k stars 324 forks source link

Remove mypy errors from python examples #2047

Open mturoci opened 1 year ago

mturoci commented 1 year ago
ng169 commented 1 year ago

i would like to work on this

mturoci commented 1 year ago

Go ahead :)

raghav24agarwal commented 11 months ago

Hi @mturoci , we have to fix all those codes based on Mypy CLI static code analyzer, is it? Also, @ng169 , are you working on this ?

mturoci commented 11 months ago

we have to fix all those codes based on Mypy CLI static code analyzer, is it?

Correct.

Swaggermuffin64 commented 11 months ago

is this finished? In that case can I work on this?

mturoci commented 10 months ago

It's still open and no PR was provided so anyone is free to work on this.

laneo1986 commented 10 months ago

Hi I have just started going through this issue, hope that is ok. just pushed a correction with background_progress.py if there is any issues with my process, let me know thanks.

mturoci commented 10 months ago

Thanks @laneo1986 we can go over your changes during PR code review. Thanks for taking the contribution initiative! :)

HarshitKmr10 commented 10 months ago

@laneo1986 are you still working on it or can I take it forward?

7460m commented 8 months ago

Hi @mturoci,

I'm a beginner to open source. I've read thought the [contributing guide] https://github.com/h2oai/wave/blob/main/.github/CONTRIBUTING.md) and set up my environment accordingly .

I have notice this issue is still open and the resent branch is been closed, so I went on to fixed the issue with my understanding of your project.

Total of 218 error has been fixed, some of the [import-untyped] error is due to the modules doesn't provided type stubs or a py.typed marker. I hope this helps :)

https://github.com/h2oai/wave/pull/2171

Devanshusisodiya commented 5 months ago

@mturoci has this issue been closed? As I was able to follow the conversation #2171 it doesn't seem like it.

laneo1986 commented 5 months ago

I am no longer working k this was told it would be sorted. Apologies

Regards

Paul

On Mon, 5 Feb 2024, 10:52 Devanshu Kumar Singh, @.***> wrote:

@mturoci https://github.com/mturoci has this issue been closed? As I was able to follow the conversation #2171 https://github.com/h2oai/wave/pull/2171 it doesn't seem like it.

— Reply to this email directly, view it on GitHub https://github.com/h2oai/wave/issues/2047#issuecomment-1926707349, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZLEBD46NNGGPUDWYWDX5TYSC2X5AVCNFSM6AAAAAAZWWZJWGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRWG4YDOMZUHE . You are receiving this because you were mentioned.Message ID: @.***>

mturoci commented 5 months ago

Hey @Devanshusisodiya. This is almost complete. I just need to brush up some final details that I didn't have much time for lately.