docs: Add tabs to docs where possible #1785

h2oai / wave

Realtime Web Apps and Dashboards for Python and R

https://wave.h2o.ai

Apache License 2.0

3.9k stars 324 forks source link

docs: Add tabs to docs where possible #1785 #2065

Closed oadeniran closed 1 year ago

oadeniran commented 1 year ago

The PR fulfills these requirements: (check all the apply)

[x] It's submitted to the main branch.
[x] When resolving a specific issue, it's referenced in the PR's title (e.g. feat: Add a button #xxx, where "xxx" is the issue number).
[x] When resolving a specific issue, the PR description includes Closes #xxx, where "xxx" is the issue number.
[ ] If changes were made to ui folder, unit tests (make test) still pass.
[ ] New/updated tests are included

My specific changes:

Tutorial-hello.md renamed to Tutorial-hello.mdx
edits to both installation.mdx files
Edited the references to tutorial-hello.md and redirected to tutorial-hello.mdx (in guide, tutorial-beer, tutorial-counter, tutorial-monitor)
edited the setup in makefile of tools/showcase from ./venv/bin/python -m playwright install to ./venv/bin/python -m playwright install-deps
The other edits and additions were automatically generated

Closes #1785

oadeniran commented 1 year ago

Hi @mturoci , I just Addressed all points you made in the edits and changes commit I think the reason why the temporary files don't delete is because my "make generate" doesn't run till the end on my wsl

mturoci commented 1 year ago

I think the reason why the temporary files don't delete is because my "make generate" doesn't run till the end on my wsl

Why doesn't it run to completion? Btw, the showcase files are still part of this PR, they should not.

I just Addressed all points you made in the edits and changes commit

There are still comments from me that didn't get answered / resolved.

oadeniran commented 1 year ago

I think the reason why the temporary files don't delete is because my "make generate" doesn't run till the end on my wsl

Why doesn't it run to completion? Btw, the showcase files are still part of this PR, they should not.

I think it doesn't run till completion due to the inadequacies of my pc. The computing power needed for matplotlib is a bit high for the project I think and after a while my wsl just gets stuck on generating a file and never gets past that stage I will remove them from the git history

I just Addressed all points you made in the edits and changes commit

There are still comments from me that didn't get answered / resolved.

oadeniran commented 1 year ago

Thanks so much for the approval @mturoci I really learned a lot on this i am thinking of posting this on LinkedIn and I was hoping if its possible for me to tag you on the post to thank you for the help and guidelines provided and also connect with you on linkedin at the same time

mturoci commented 1 year ago

Sure, np :) Glad you learned something.