The PR fulfills these requirements: (check all that apply)
[x] It's submitted to the main branch.
[x] When resolving a specific issue, it's referenced in the PR's title (e.g. feat: Add a button #xxx, where "xxx" is the issue number).
[x] When resolving a specific issue, the PR description includes Closes #xxx, where "xxx" is the issue number.
[x] If changes were made to ui folder, unit tests (make test) still pass.
[x] New/updated tests are included
This PR addresses all issues found after final revision of #1154. Included issues are:
Checklist - set values to None, select value manually, set values to None once again (unable to set to None)
Tabs - dynamic value change is fully supported for ui.tab_card only, but not for ui.tabs - try to set value dynamically, select tab manually, set value dynamically to the same value as before (Tab is not switching)
Combobox single/multi - when choices are set to None it leads to endless loop
Dropdown - dialog single/multi - when choices are set to None it leads to endless loop
Nav - user was unable to dynamically unselect all items by specifying value=None within the Wave app when component was initially rendered with some value
Also this PR adjusts the behavior of Nav/Tab/Tabs in following manner:
Revert behavior for Menu - when value is set to None, no item is active
Keep behavior for Tab/Tabs - when value is set to None, first item is active by default - we are not bringing support for #1776
The PR fulfills these requirements: (check all that apply)
main
branch.feat: Add a button #xxx
, where "xxx" is the issue number).Closes #xxx
, where "xxx" is the issue number.ui
folder, unit tests (make test
) still pass.This PR addresses all issues found after final revision of #1154. Included issues are:
None
, select value manually, set values toNone
once again (unable to set toNone
)ui.tab_card
only, but not forui.tabs
- try to set value dynamically, select tab manually, set value dynamically to the same value as before (Tab is not switching)choices
are set toNone
it leads to endless loopchoices
are set toNone
it leads to endless loopvalue=None
within the Wave app when component was initially rendered with some valueAlso this PR adjusts the behavior of Nav/Tab/Tabs in following manner:
None
, no item is activeNone
, first item is active by default - we are not bringing support for #1776Closes #1154 Closes #1776