#2047 - Future variable found a float expected an int, changed line 29 to int()

h2oai / wave

Realtime Web Apps and Dashboards for Python and R

https://wave.h2o.ai

Apache License 2.0

3.9k stars 323 forks source link

#2047 - Future variable found a float expected an int, changed line 29 to int() #2122

Closed laneo1986 closed 8 months ago

laneo1986 commented 10 months ago

The PR fulfills these requirements: (check all the apply)

[ ] It's submitted to the main branch.
[ ] When resolving a specific issue, it's referenced in the PR's title (e.g. feat: Add a button #xxx, where "xxx" is the issue number).
[ ] When resolving a specific issue, the PR description includes Closes #xxx, where "xxx" is the issue number.
[ ] If changes were made to ui folder, unit tests (make test) still pass.
[ ] New/updated tests are included

laneo1986 commented 10 months ago

Thanks @laneo1986. Please rerequest the review once all the errors are resolved so that I can do a bulk review instead of one by one.

Apologies, will do that

mturoci commented 9 months ago

@laneo1986 are you still working on this or can I close the PR?

laneo1986 commented 9 months ago

I'm no longer working on this apologies

On Mon, 9 Oct 2023, 11:29 Martin Turóci, @.***> wrote:

@laneo1986 https://github.com/laneo1986 are you still working on this or can I close the PR?

— Reply to this email directly, view it on GitHub https://github.com/h2oai/wave/pull/2122#issuecomment-1752749797, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZLEBBLAXUVQKCKRP37LQ3X6PGZPAVCNFSM6AAAAAA4EG6QCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJSG42DSNZZG4 . You are receiving this because you were mentioned.Message ID: @.***>