fix: Apply primary button styles for icon button #2121

h2oai / wave

Realtime Web Apps and Dashboards for Python and R

https://wave.h2o.ai

Apache License 2.0

3.98k stars 327 forks source link

fix: Apply primary button styles for icon button #2121 #2137

Closed marek-mihok closed 1 year ago

marek-mihok commented 1 year ago

The PR fulfills these requirements: (check all the apply)

[x] It's submitted to the main branch.
[x] When resolving a specific issue, it's referenced in the PR's title (e.g. feat: Add a button #xxx, where "xxx" is the issue number).
[x] When resolving a specific issue, the PR description includes Closes #xxx, where "xxx" is the issue number.
[x] If changes were made to ui folder, unit tests (make test) still pass.
[ ] New/updated tests are included

Closes #2121

marek-mihok commented 1 year ago

What's the reason for not using the existing Fluent.PrimaryButton instead of mimicking it with custom styles?

@mturoci the primary button with icon only is much wider than icon button (it has horizontal padding)

mturoci commented 1 year ago

I don't understand. That's the point of the issue, isn't it? If primary=True, render a primary button. The padding is specific to primary button styles which is desired - so that people understand it's primary.