h2oai / wave

Realtime Web Apps and Dashboards for Python and R
https://wave.h2o.ai
Apache License 2.0
3.9k stars 323 forks source link

Fixed bug in metadata where \n isn't recognized as a new line. #2142

Closed MattiasOz closed 9 months ago

MattiasOz commented 9 months ago

The PR fulfills these requirements: (check all the apply)

mturoci commented 9 months ago

Hello @MattiasOz. Can you provide a further explanation about what was the actual problem you solved?

MattiasOz commented 9 months ago

I'm on arch and couldn't run any of the examples. The make all command would write # Generated in hatch_build.py\n__platform__ = 'linux'\n__arch__ = 'amd64' exactly like that. The \n wasn't recognized as a new line making the whole file a comment.

mturoci commented 9 months ago

Makes sense, thanks for the clarification!

mturoci commented 9 months ago

Let's see if the -e option does not break Ubuntu/Win e2e tests.

mturoci commented 9 months ago

As expected, it doesn't work on any of the other mainstream OSes since -e is an unknown option.

mturoci commented 9 months ago

Thus reverting.