The PR fulfills these requirements: (check all the apply)
[x] It's submitted to the main branch.
[x] When resolving a specific issue, it's referenced in the PR's title (e.g. feat: Add a button #xxx, where "xxx" is the issue number).
[x] When resolving a specific issue, the PR description includes Closes #xxx, where "xxx" is the issue number.
[x] If changes were made to ui folder, unit tests (make test) still pass.
[x] New/updated tests are included
The problem was the implementation of onEmptyResolveSuggestions callback. As Fluent API description says, it is
A callback for what should happen when suggestions are shown without input provided. Returns the already selected items so the resolver can filter them out.
In our case it was returning initial tags (() => tags) instead of filtered ones.
The PR fulfills these requirements: (check all the apply)
mainbranch.feat: Add a button #xxx, where "xxx" is the issue number).Closes #xxx, where "xxx" is the issue number.uifolder, unit tests (make test) still pass.The problem was the implementation of
onEmptyResolveSuggestionscallback. As Fluent API description says, it isIn our case it was returning initial tags (
() => tags) instead of filtered ones.https://github.com/h2oai/wave/assets/23740173/6c7ab461-ca83-418a-bed7-3c3d166d6b89
Closes #1985