packaging: Integrate github workflows to automate the air-gapping process of wave Tour

h2oai / wave

Realtime Web Apps and Dashboards for Python and R

https://wave.h2o.ai

Apache License 2.0

3.9k stars 323 forks source link

packaging: Integrate github workflows to automate the air-gapping process of wave Tour #2199

Closed sulhicader closed 4 months ago

sulhicader commented 7 months ago

The PR fulfills these requirements: (check all the apply)

[ ] It's submitted to the main branch.
[ ] When resolving a specific issue, it's referenced in the PR's title (e.g. feat: Add a button #xxx, where "xxx" is the issue number).
[ ] When resolving a specific issue, the PR description includes Closes #xxx, where "xxx" is the issue number.
[ ] If changes were made to ui folder, unit tests (make test) still pass.
[ ] New/updated tests are included

Closes #2180

mturoci commented 3 months ago

@sulhicader https://github.com/h2oai/wave/actions/runs/8254859486/job/22580763018

sulhicader commented 3 months ago

@mturoci reason for the workflow failure is "ERROR: No matching distribution found for h2o_wave==1.1.1". Are there any time gap to install the h2o_wave latest release from the PYPI after publishing. As I understood some steps in release job of the workflow push the h2o_wave to PYPI. And the failed job start once the release job is finished.

mturoci commented 3 months ago

Yes, seems like the problem is PyPI needs more time between publish and subsequent download to serve the updated file.

sulhicader commented 3 months ago

One thing We can do is using the wheel file to install the h2o_wave. For docker images We only need the linux version. If it is same for the tour wave bundle publishing to the s3 then We can simply add an extra line to copy the whl file. Or another way came to my mind is, add an extra step with sleep command in failed job to delay the image building task if it is a short and known time to become the PYPI h2o_wave available.

mturoci commented 3 months ago

Installing from wheel sounds okay to me (for docker images only).

sulhicader commented 3 months ago

@mturoci fixed in https://github.com/h2oai/wave/pull/2289