The PR fulfills these requirements: (check all the apply)
[x] It's submitted to the main branch.
[x] When resolving a specific issue, it's referenced in the PR's title (e.g. feat: Add a button #xxx, where "xxx" is the issue number).
[x] When resolving a specific issue, the PR description includes Closes #xxx, where "xxx" is the issue number.
[x] If changes were made to ui folder, unit tests (make test) still pass.
[x] New/updated tests are included
Fixed by updating FluentUI to slightly newer version supporting custom onItemsChanged event callback fired after Fluent internal items are updated but before onSelectionChanged. This way we can prevent select event from being emitted anytime items are updated. Now the only way of firing the event is to select/deselect row or select/deselect all rows.
Both unit and visual regression tests pass after FluentUI update.
The PR fulfills these requirements: (check all the apply)
mainbranch.feat: Add a button #xxx, where "xxx" is the issue number).Closes #xxx, where "xxx" is the issue number.uifolder, unit tests (make test) still pass.Fixed by updating FluentUI to slightly newer version supporting custom
onItemsChangedevent callback fired after Fluent internalitemsare updated but beforeonSelectionChanged. This way we can preventselectevent from being emitted anytimeitemsare updated. Now the only way of firing the event is to select/deselect row or select/deselect all rows.Both unit and visual regression tests pass after FluentUI update.
https://github.com/h2oai/wave/assets/23740173/8e541660-bcf8-4ca5-b5d1-a62f3468ccc9
Closes #2196