h2oai / wave

Realtime Web Apps and Dashboards for Python and R
https://wave.h2o.ai
Apache License 2.0
3.9k stars 323 forks source link

fix: Raise error if waved cannot find public/private dir #2130 #2213

Open 92ammarraza opened 6 months ago

92ammarraza commented 6 months ago

The PR fulfills these requirements: (check all the apply)

Related issue #2130

Overview: This pull request addresses the issue #2130 , where waved would start without error even if the specified public/private directories were missing or incorrectly configured. The changes introduce error checking during server startup to ensure these directories exist and are accessible.

Changes:

Testing

Closes #2130

mturoci commented 6 months ago

Hey @92ammarraza. Make sure the comments are addressed in the correct branch. File changes view doesn't show your latest changes.

92ammarraza commented 6 months ago

Hey @mturoci , Me and @johnmrzo are working together in team on this for a class. He has pushed the latest changes. Looking forward to your feedback.