Open kaitlyncliu opened 6 months ago
Hi @mturoci
I added the python example file called table_progress.py
, wrote documentation for https://wave.h2o.ai/docs/widgets/form/table/, changed the attribute from type
to compact
using make generate
, and cleaned up the CSS, but am still unsure about the width of the progress arc and bar being fluid instead of a set number. Please let me know what you think and if there are any more changes necessary!
The changes look better now. Good job @kaitlyncliu!
am still unsure about the width of the progress arc and bar being fluid instead of a set number.
I meant this:
https://github.com/h2oai/wave/assets/64769322/a5f70c58-2382-4388-8ecd-3491b5224f03
Hint: Have a look at flexbox and its flex-grow prop :)
The PR fulfills these requirements: (check all the apply)
main
branch.feat: Add a button #xxx
, where "xxx" is the issue number).Closes #xxx
, where "xxx" is the issue number.ui
folder, unit tests (make test
) still pass.[ ] New/updated tests are included
@kellyycha and I fixed this issue by adding a new keyword argument
type
in the progress_table_cell_type that allows users to implement a bar style progress cell with the progress value indicated to the left of the bar, reducing the height of the row.This is how the table.py example looks originally:![Screenshot 2023-12-06 at 12 14 35 PM](https://github.com/h2oai/wave/assets/84979255/3fe33b47-f58c-428e-9859-1c1667da6612)
Without the Progress column, the row height would look like this, which has a row height that is noticeably shorter than with the Progress:
Our implementation results in a bar that looks like the following and maintains a similar row height to the row without a progress cell:![Screenshot 2023-12-06 at 12 14 21 PM](https://github.com/h2oai/wave/assets/84979255/24d795bf-987e-446e-9814-ad7f64879ac2)
We default
type
to the spinner/arc progress indicator so that previously implemented tables will continue to look the same.The UI and unit tests still pass:
Closes #1921