search

h2oai / wave

Realtime Web Apps and Dashboards for Python and R
https://wave.h2o.ai
Apache License 2.0
3.9k stars 323 forks source link

Not enough contrast between notification bar background and close button in `h2o-dark` theme #2241

Closed nipunchamikara closed 5 months ago

nipunchamikara commented 5 months ago

Wave SDK Version, OS

Wave v1.0.0 MacOS v14.3

Actual behavior

I'm currently working on a Wave App that has a light and dark mode, where it uses default and h2o-dark themes respectively. When using h2o-dark, the close button in notification bar is not discernible. It is visible when using the default theme.

Expected behavior

Either the background of the notification bar should change with the theme, or the color of the close button should remain fixed.

Steps To Reproduce

  1. Set q.page["meta"].theme to h2o-dark
  2. Set q.page["meta"].notification_bar to ui.notification_bar component
mturoci commented 5 months ago

Thanks for reporting @nipunchamikara!