h2oai / wave

Realtime Web Apps and Dashboards for Python and R
https://wave.h2o.ai
Apache License 2.0
3.9k stars 323 forks source link

fix: Make conda package support multiple python versions #2227 #2247

Closed marek-mihok closed 5 months ago

marek-mihok commented 5 months ago

The PR fulfills these requirements: (check all the apply)

The problem was that the package only supports the version of python it was built in. It can be solved by specifying noarch: python inside meta.yaml conda config file. The result is the single platform independent package supporting multiple python versions.

Also update of the pipeline build action (amauryval/publish_conda_package_action) to version 2.0.3 is necessary, because it allows specifying noarch value as the Platforms parameter.

Closes #2227

marek-mihok commented 5 months ago

We probably want to sync publish conda step in release-wave with publish-conda job as well.

@mturoci what is it used for? Is it for cases when you want to publish conda without going through all release process? It has no runs yet.

image

Also is CondaDir: 'py/conda' in publish-conda.yml instead of CondaDir: 'py/h2o_wave/conda' intentional? And what exactly do you mean by "sync"?

mturoci commented 5 months ago

Is it for cases when you want to publish conda without going through all release process?

Yes.

is CondaDir: 'py/conda' in publish-conda.yml instead of CondaDir: 'py/h2o_wave/conda' intentional?

Probably not. Seems like a leftover, but better check.

And what exactly do you mean by "sync"?

They should be the same. No matter which workflow I use, I want the output to be identical.

marek-mihok commented 5 months ago

@mturoci synced. Can we try to run publish-conda separately first to prevent release-wave from potential failing?