The PR fulfills these requirements: (check all the apply)
[x] It's submitted to the main branch.
[x] When resolving a specific issue, it's referenced in the PR's title (e.g. feat: Add a button #xxx, where "xxx" is the issue number).
[x] When resolving a specific issue, the PR description includes Closes #xxx, where "xxx" is the issue number.
[x] If changes were made to ui folder, unit tests (make test) still pass.
[x] New/updated tests are included
Adds path and download attributes to ui.command to support the same behavior as ui.link():
export interface Command {
/** An identifying name for this component. If the name is prefixed with a '#', the command sets the location hash to the name when executed. */
name: Id
/** The text displayed for this command. */
label?: S
/** The caption for this command (typically a tooltip). */
caption?: S
/** The icon to be displayed for this command. */
icon?: S
/** Sub-commands, if any */
items?: Command[]
/** Data associated with this command, if any. */
value?: S
/** The path or URL to link to. The 'items' and 'value' props are ignored when specified. */
path?: S
/** True if the link should prompt the user to save the linked URL instead of navigating to it. */
download?: B
}
The PR fulfills these requirements: (check all the apply)
main
branch.feat: Add a button #xxx
, where "xxx" is the issue number).Closes #xxx
, where "xxx" is the issue number.ui
folder, unit tests (make test
) still pass.Adds
path
anddownload
attributes to ui.command to support the same behavior asui.link()
:Closes #2224