h2oai / wave

Realtime Web Apps and Dashboards for Python and R
https://wave.h2o.ai
Apache License 2.0
3.9k stars 323 forks source link

fix: Set ui.inline justify default to start #2267 #2272

Closed marek-mihok closed 4 months ago

marek-mihok commented 4 months ago

The PR fulfills these requirements: (check all the apply)

Adds lacking start default to ui.inline() justification as declared in the API description.

This change affects only one example: image

Closes #2267

mturoci commented 4 months ago

Shouldn't the screenshots show the opposite? The goal of the issue is setting the alignment to start so that elements are in a row starting from left, progressing to the right taking up only their intrinsic size. The screenshots look like they are using some kind of space-between variant or something.

marek-mihok commented 4 months ago

that elements are in a row starting from left, progressing to the right taking up only their intrinsic size

@mturoci , the left part of the screenshot is the fixed implementation and the "space-between" variant is the old (wrong) one.

mturoci commented 4 months ago

Got it. I assumed you are showing the change this PR introduced, hence base = old, compare = new. If it's the opposite, all is good.