feat: v1.1.0 pre-release QA based fixes #2276 - Githubissues

h2oai / wave

Realtime Web Apps and Dashboards for Python and R

https://wave.h2o.ai

Apache License 2.0

3.9k stars 323 forks source link

feat: v1.1.0 pre-release QA based fixes #2276 #2277

Closed marek-mihok closed 3 months ago

marek-mihok commented 3 months ago

The PR fulfills these requirements: (check all the apply)

[x] It's submitted to the main branch.
[x] When resolving a specific issue, it's referenced in the PR's title (e.g. feat: Add a button #xxx, where "xxx" is the issue number).
[x] When resolving a specific issue, the PR description includes Closes #xxx, where "xxx" is the issue number.
[x] If changes were made to ui folder, unit tests (make test) still pass.
[x] New/updated tests are included

This PR fixes several issues based on the v1.0.0 pre-release QA, namely:

Audio annotator: Wrong annotator dimensions if Wave app is loaded when browser tab is not visible
Audio annotator: In specific scenario user was able to activate empty tag and annotate with it
Toolbar: Download prop example was not working due to link being from different origin.

TBD:

[x] Firefox "randomly" dropping Wave server connection since this commit. - Fixed by #2278
[ ] Audio annotator playback issues for several file formats when using Safari and/or Firefox. - TBD later as agreed.

Closes #2276