docs: Update docs with preferred way of displaying documents #2291

h2oai / wave

Realtime Web Apps and Dashboards for Python and R

https://wave.h2o.ai

Apache License 2.0

3.9k stars 323 forks source link

Closed marek-mihok closed 2 months ago

marek-mihok commented 2 months ago

The PR fulfills these requirements: (check all the apply)

[x] It's submitted to the main branch.
[x] When resolving a specific issue, it's referenced in the PR's title (e.g. feat: Add a button #xxx, where "xxx" is the issue number).
[x] When resolving a specific issue, the PR description includes Closes #xxx, where "xxx" is the issue number.
[ ] If changes were made to ui folder, unit tests (make test) still pass.
[ ] New/updated tests are included

Closes #2291

marek-mihok commented 2 months ago

For some reason PDF in /docs/widgets/form/frame/#with-document section is not rendered:

The path seems to be correct. @mturoci could you please check where could be the problem?

mturoci commented 2 months ago

@marek-mihok the problem is in Playwright - headless mode does not render pdfs for some reason, but headed does. See https://github.com/h2oai/wave/issues/2314.