h2oai / wave

Realtime Web Apps and Dashboards for Python and R
https://wave.h2o.ai
Apache License 2.0
3.98k stars 328 forks source link

panic: close of closed channel #2315

Closed MaksymSofer closed 4 months ago

MaksymSofer commented 5 months ago

Wave SDK Version, OS

Ubuntu 22.04 wave 1.1.1 python 3.10 Server hosted in Kubernetes cluster in AWS behind CloudflareD

Actual behavior

Some of connections to server, just kill the server

INFO: 127.0.0.1:55606 - "POST /disconnect HTTP/1.1" 200 OK 2024/04/15 11:20:18 # {"client":"19dd6178-8681-49ca-a1bd-93079a911f13","t":"client_unsubscribe"} panic: close of closed channel

goroutine 6 [running]: github.com/h2oai/wave.(Client).quit(...) /home/runner/work/wave/wave/client.go:306 github.com/h2oai/wave.(Broker).dropClient(0xc00015ccf0, 0xc0003fc0c0) /home/runner/work/wave/wave/broker.go:292 +0x74 github.com/h2oai/wave.(*Broker).run(0xc00015ccf0) /home/runner/work/wave/wave/broker.go:236 +0x167 created by github.com/h2oai/wave.Run /home/runner/work/wave/wave/server.go:91 +0x4bc ERROR:h2o_wave.server:Unhandled exception ConnectionResetError: [Errno 104] Connection reset by peer

Expected behavior

this behavior is not expected

Steps To Reproduce

Locally issue not seems to be reproducible in cloud each fifth connection seems to be killing the server