h2oai / wave

Realtime Web Apps and Dashboards for Python and R
https://wave.h2o.ai
Apache License 2.0
3.9k stars 323 forks source link

Markdown table formatting has been broken #2339

Closed dulajra closed 3 weeks ago

dulajra commented 3 weeks ago

Wave SDK Version, OS

Wave 1.1.0

Actual behavior

Screenshot 2024-06-04 at 16 01 43

Expected behavior

Screenshot 2024-06-04 at 16 02 26

Steps To Reproduce

from h2o_wave import site, ui, main

def make_markdown_row(values):
    return f"| {' | '.join([str(x) for x in values])} |"

def make_markdown_table(fields, rows):
    return '\n'.join([
        make_markdown_row(fields),
        make_markdown_row('-' * len(fields)),
        '\n'.join([make_markdown_row(row) for row in rows]),
    ])

page = site['/demo']

fields = ['Column 1', 'Column 2']
rows = [['Row 1 Column 1', 'Row 1 Column 2'], ['Row 2 Column 1', 'Row 2 Column 2']]

v = page.add('example', ui.form_card(
    box='1 1 4 5',
    items=[
        ui.text(make_markdown_table(
            fields=fields,
            rows=rows
        ),),
    ],
))

page.save()
dulajra commented 3 weeks ago

@mturoci Can you please check? Assign option is disabled for me. cc: @jakubhava

jakubhava commented 3 weeks ago

We are not looking necessarily for a fix @mturoci , if you could please suggest a workaround if any, that would be great as well

mturoci commented 3 weeks ago

Seems like a build problem of some sort:

image

@marek-mihok any ideas?

marek-mihok commented 3 weeks ago

@marek-mihok any ideas?

@mturoci, vite build had problem with this React.useEffect(() => { import('./markdown.css') }, []), also if awaited.

Fixed by #2341