search

h2oai / xgboost

Scalable, Portable and Distributed Gradient Boosting (GBDT, GBRT or GBM) Library, for Python, R, Java, Scala, C++ and more. Runs on single machine, Hadoop, Spark, Flink and DataFlow
Other
44 stars 26 forks source link

[SW-2437] relocate to ai.h2o package #88

Closed honzasterba closed 3 years ago

michalkurka commented 3 years ago

I like this approach!

An alternative approach would be to use the existing java sources and "generate" new sources with packages relocated.

This would allow us to publish also source code (jars) that is corresponding exactly to the artifacts.

ml.dmlc.xgboost4j.java -> ai.h2o.xgboost4j.java

Since we are doing a straightforward move a simple (recursive) sed would do the job.

WDYT?

honzasterba commented 3 years ago

@mn-mikke I did some research and loading two libs with same symbols should not be an issue as long as they are under different classloaders

mn-mikke commented 3 years ago

@honzasterba Perfect! Thanks for checking it.