search

h2zero / esp-nimble-cpp

C++ library for the esp32 NimBLE stack based on and mostly compatible with @nkolban cpp_utils BLE library.
https://h2zero.github.io/esp-nimble-cpp/
Apache License 2.0
181 stars 62 forks source link

Fix compilation errors in some situations. #236

Closed h2zero closed 1 day ago

h2zero commented 1 week ago

Fixes #234

iranl commented 6 days ago

I believe this issue was introduced in a recent update of ESP-IDF 5.3. There is an issue about this here https://github.com/espressif/esp-idf/issues/14840, which is already fixed by https://github.com/espressif/esp-nimble/commit/ca6c6173fca923cfa1966891fc6623fd9f9cb323.

So not sure if this change on the side of esp-nimble-cpp is needed (at least not long term).

h2zero commented 6 days ago

Thanks, it will be needed as this commonly breaks due to NimBLE defining min/max in headers and conflicting anywhere we #include <string>. I'm inclined to keep this change here.