Closed selinali2010 closed 2 years ago
Looks AMAZING!! Couple nitpicky things and comments
Looks AMAZING!! Couple nitpicky things and comments
- I notice the numbers truncate when you have trailing zeros. Can we make it so that numbers only truncate to a tenth. (So 4 db should show as 4.0, and 4.01 as is)
I'm starting to think we should just make the gain box have arrows too for consistency, but also for consistency
- The quality and gain input boxes should always show 1 decimal place as above.
- The up/down arrows IN the box itself should adjust both by the tenth of a decimal
- The slider up and down arrows are fine to increase the gain up and down by a whole decibel instead of a tenth since moving the slider itself only adjusts by whole decimal places
- Moving the slider knob seems to adjust to the closest decibel, can we make it so that it leaves the places after the decimal place the same?
- I think we need to take the plunge on setting the min max limits for the gain to be -20 to 20, the current range is too squished for -30 to 30. On that note, the bands don't actually fill up all the space in their bordered component, could we increase their height (but without changing the preamp gain height?)
- On a separate note so I don't forget, we should start thinking about window resizing (auto resizing when you add a slider within the width of the screen, etc)
Ok, I think I covered almost everything here except a couple:
NumberInput
s now compute a maxIntegerDigits
value that limits how many numbers can be typed prior to a decimal point.
Changes
For the
Slider
componentFor
RangeInput
componentincrementPrecision
so we can specify the precision of its increment (default of 0 means default to integers)For backend stuff
setPreampGain
to parse float instead of integersFor tests
RangeInput
Slider
0.3
instead of3