JAT-79 Add and remove specific bands

h39s / AQUA

A system-wide parametric equalizer interface for Windows

GNU General Public License v3.0

159 stars 7 forks source link

JAT-79 Add and remove specific bands #25

Closed selinali2010 closed 2 years ago

selinali2010 commented 2 years ago

Backend

Add util for computing average frequencies (+ tests)
Update ADD_FILTER event to take an optional index
- add to the end by default

Frontend

Create AddSliderDivider component for adding sliders
Create button for removing slider in FrequencyBand component
Remove add/remove button column from the right hand side
Add styles for fading in the dividers and the remove buttons
Add style for the remove icon and for blurring the band being deleted

linear[bot] commented 2 years ago

JAT-79 Add and remove specific bands

User should be able to add bands in between existing ones * the added band will either be a duplicate frequency of one of its neighbours, or be an average frequency between the two * all other properties should be the default (0dB gain, peak filter, 1 quality) to prevent audio changes User should be able to remove a specific band * add UI element for deleting a specific band See figma mockup

selinali2010 commented 2 years ago

@hemit-s @xenown when you review/play around with this branch, plz consider:

Should we add a unique identifier to each slider?
How does the UI feel? Are there improvements that can be made?
Is the logarithmic average a good way to add frequencies in between? Or should we go back to linear averages?