search

h3abionet / afpo

AfPO: African Population Ontology
1 stars 0 forks source link

Appropriate use of object properties #16

Closed Melek-C closed 5 months ago

Melek-C commented 8 months ago

Two upper level classes, Continent and Population.

TODO Definition formatting: should follow standard formatting. Beginning with the parent term. The definition sentence structure should be grammatically correct.

This ontology is using the property "see Also" for sources of the Class data/information. expect to see this kind of information under 'definition_source' TODO -- Consult IAO (Information Artifact Ontology)

There are many AfPO specific properties, e.g., AfPO:0000152, which is annotated with a PubMed URL. Instead of the AfPO property, the ontology could use hasDbXref TODO. - review duplications in property annotations:

anitacaron commented 8 months ago
anitacaron commented 5 months ago

TODO Definition formatting: should follow standard formatting. Beginning with the parent term. The definition sentence structure should be grammatically correct.

This ontology is using the property "see Also" for sources of the Class data/information. expect to see this kind of information under 'definition_source' TODO -- Consult IAO (Information Artifact Ontology)

Fixed in PR #5

anitacaron commented 5 months ago

There are many AfPO specific properties, e.g., AfPO:0000152, which is annotated with a PubMed URL. Instead of the AfPO property, the ontology could use hasDbXref TODO. - review duplications in property annotations:

The AfPO-specific annotations bring more information; for example, there is an annotation for cross reference for population (AfPO:0000600) and another for language (AfPO:0000601). We classified these two annotations under oboInOwl:hasDbXref. For population:genetic:study (AfPO:0000152) and population:microbiome:study (AfPO:0000226) we classified them as AfPO:0000600. Done in PR #41

anitacaron commented 5 months ago

After PR #41 is merged, we can close this issue.