search

h3imdall / ftp-remote-edit

Edit files on ftp servers with Atom editor and without a workspace.
MIT License
178 stars 26 forks source link

configArray is not defined when using Pulsar #446

Closed rheeqp closed 1 year ago

rheeqp commented 1 year ago

When using Pulsar version 1.101.0-beta, i got this error:

configArray is not defined
[Hide Stack Trace](https://github.com/h3imdall/ftp-remote-edit/issues/new#)
ReferenceError: configArray is not defined
    at Storage.load (storage.js:56:22)
    at ConfigurationView.close (configuration-view.js:765:13)
    at HTMLButtonElement.<anonymous> (configuration-view.js:80:12)
brunoalbim commented 1 year ago

I have the same problem.

I migrated from a notebook, from Windows to MAC, so I needed to install the atom to use the ftp-remote-edit pack, but I can't search for the packs using the atom.

so I downloaded the pulsar, but it gives the same error.

I saw that this error is only happening in Pulsar, because I downloaded the atom, even archived, and manually copied the files from ftp-remote-edit and added them to the "packages" folder of the atom, so I was able to use and connect via ftp.

however on Pulsar, it gives this same problem.

Do you have a compatibility prediction?

it would be really good.

IggsGrey commented 1 year ago

On line 56 of this file configArray was used without an initializer, neither was it ever initialized within the file. Hence the variable is clearly undefined. It's a bit weird why it only happens in pulsar and not in atom, however i suppose it could be due to a missing update in apm.

The problem now is, how do we get @h3imdall to solve it or merge a pull request?

IggsGrey commented 1 year ago

This PR seems to have a fix

Luishi5000 commented 1 year ago

In the meantime, how do we get that PR to work with Pulsar? I've downloaded the fork but don't know where the package files go on MacOS.

rheeqp commented 1 year ago

https://github.com/h3imdall/ftp-remote-edit/issues/446#issuecomment-1425562126

I've used this PR, seems good

IggsGrey commented 1 year ago

@Luishi5000 and anyone else who might find this helpful.

To use this PR

Just copy (and overwrite) the contents of the downloaded files from the fork, to the package installation folder.

On my MacOS, it is located at /Users/[USERNAME]/.pulsar/packages/ftp-remote-edit On Ubuntu, it is located at /usr/lib/pulsar/packages/ftp-remote-edit

cschindl commented 1 year ago

I have made the adjustments, merged into the master and am now trying to release a new version. Unfortunately it is not as easy as it was under atom. (https://github.com/orgs/pulsar-edit/discussions/91)

I hope the problem can be fixed quickly, so that you can download/install the new version in Pulsar again without any problems.

rheeqp commented 1 year ago

I have made the adjustments, merged into the master and am now trying to release a new version. Unfortunately it is not as easy as it was under atom. (https://github.com/orgs/pulsar-edit/discussions/91)

I hope the problem can be fixed quickly, so that you can download/install the new version in Pulsar again without any problems.

thank you so much.

cschindl commented 1 year ago

I was now able to successfully update the package on the pulsar package registry. The package can now be easily updated from within pulsar and should be fully functional from version v0.20.0.