search

h3imdall / ftp-remote-edit

Edit files on ftp servers with Atom editor and without a workspace.
MIT License
178 stars 27 forks source link

减少或者消除 puslar使用过程中的报错和提示 #447

Closed xingkongwuhen closed 1 year ago

xingkongwuhen commented 1 year ago

减少或者消除 puslar使用过程中的报错和提示

IggsGrey commented 1 year ago

To speed things up, above means: "To reduce or eliminate errors and warnings during the use of Puslar"

xingkongwuhen commented 1 year ago

修复了再Pulsar编辑器使用的时候出现的包含但不限于configArray在内的几个问题，使得Pulsar上可以正常使用这个FTP插件;目前我发现的最主要的问题是pulsar好像 使用了强校验模式所以部分没有生命的变量是提示错误；

IggsGrey commented 1 year ago

Correct, basically I don't think it's even good practice to write code in that way. Particularly let and const should be used instead of var as most "experts" say. However given the existing code structure it may not be worth the effort to refactor the entire code base.

So let's hope this one gets merged soon, otherwise I propose that you create a fork of this? Given that you have the time to maintain.

cschindl commented 1 year ago

Thanks for the changes. I have merged everything and now try to publish a new version. Unfortunately it is not as easy as it was under atom. (https://github.com/orgs/pulsar-edit/discussions/91)