search

h3llb3nt / marquee_gifs

collection point for art for tty2rgbmatrix, web2rgbmatrix, etc
6 stars 2 forks source link

Repo Discussion #2

Closed kconger closed 2 years ago

kconger commented 2 years ago

I opened this issue for us to discuss repo structure and standards.

kconger commented 2 years ago

In response to @h3llb3nt's last message in the PR

hey guys, sorry been away, finished going thru the existing files and parsed out what wasn't unreadable or not valid to MiSTer at this time. I pushed the directory structure. want them in a 128x32 top level folder as well for future resolution shenanigans?

No problem, thanks for doing all that work!

A couple reasons I had the images for games/systems without cores. Besides having images ready for future MiSTer cores, I was thinking of adding a RetroPie based service at some point. Who knows if I'll get to it since I don't really use it anymore.

also renamed files to line up with mister core names. however, I still want to come up with a way to credit the source of the file... at first I had just put the different sources into different folders but if we use this method that goes out the window. thoughts?

Maybe a AUTHORS file at the top level?

h3llb3nt commented 2 years ago

AUTHORS file is a good idea.

yeah, i see why the other files were there for future cores. i'll go back thru and see if there are any i passed over because they weren't on the current or future development google sheet i was referencing. i guess the only issue i see with including images for cores that don't exist yet is naming them...

the only other thing i'll mention is that for me, any of the animations have to have the title of the game on them otherwise its not a marquee which is why i left several of the animations out. some of them are quite good but they just show gameplay and not the game title but could be modified to have the marquee integrated which is why i pulled what i did. for instance the robocop.gif is great and shows a good example of gameplay but it does't show the title right now. but i can fix that.

kconger commented 2 years ago

The arcade core GIFs I had added all matched their mame romset name, which MiSTer cores seem to follow, so I don't think naming should be an issue with them. The console/system cores GIFs are just guesses at this point, and would probably need to be renamed if/when a core comes out.

A somewhat related matter do the tty2* projects want to standardize the naming we use for systems broken out of multi-system cores. This is what I'm currently doing

h3llb3nt commented 2 years ago

oh of course the mame romset has the naming. duh!

venice1200 commented 2 years ago

Thanks to both of you for your work. I like the AUTHORS file idea as well.

MGL's are a great addition (I was waiting for something like this), so I can get rid of the multi-language support withtin tty2oled as everybody can use his own style for his Games/Console as long he is following the naming convention.

Cheers

kconger commented 2 years ago

oh of course the mame romset has the naming. duh!

I've submitted a PR that restores the mame marquees and some others.

kconger commented 2 years ago

Thanks to both of you for your work. I like the AUTHORS file idea as well.

MGL's are a great addition (I was waiting for something like this), so I can get rid of the multi-language support withtin tty2oled as everybody can use his own style for his Games/Console as long he is following the naming convention.

Cheers

I wound if our projects should use a shared repo for MGL files?

venice1200 commented 2 years ago

Is anything unclear or can we start to use this repository?

kconger commented 2 years ago

I have a branch ready to use the new structure. I also have an open PR to add back the mame marquees, that needs h3llb3nt's review/approval.

I think we just need to get the PR merged and have h3llb3nt make the repo public.

h3llb3nt commented 2 years ago

pr merged... i'll make it public