search

h3llrais3r / deluge-myscheduler

Modified deluge scheduler plugin with 'force start' support
19 stars 4 forks source link

added a scheduler override that ignores the schedule #8

Closed akennedy4155 closed 5 years ago

akennedy4155 commented 5 years ago

On / Off tick box within the preferences that allows the user to override the schedule and use normal operation.

h3llrais3r commented 5 years ago

Please also add option in webui and can you also provide screenshots from webui and gtkui changes?

akennedy4155 commented 5 years ago

Yep. Going for a hike and I can get it when I get home in a few hours

h3llrais3r commented 5 years ago

Can you also explain the usage of this option? Because you can achieve the same by just disabling the scheduler plugin itself if you don't want the scheduler. :wink:

h3llrais3r commented 5 years ago

Actually, I already implemented it myself. :wink: I used your PR as reference but modified it a bit and added the webui part. Can you check it and give me feedback? It's implemented in the ignore_schedule branch (https://github.com/h3llrais3r/deluge-myscheduler/tree/ignore-schedule).

If you confirm it's doing as expected, I'll merge it in the master and make a new release.

akennedy4155 commented 5 years ago

I just saw this after making changes to add the WebUI. I had never used this before and I didn't realize that this was a feature that Deluge had. I'll checkout your branch and see how it looks!

akennedy4155 commented 5 years ago

Looks good! You definitely know the code better than I do. I added lots of OR logic within the if statements in different parts of the code but you took it to a higher level and just returned a Green state from there which I think is an awesome implementation.

To answer your question from before...

The use case for why I wanted this feature originally starts like this: I have to keep my torrents seeding at night to maintain ratio, but I don't want them to go off during the day because it slows down the internet. 8 hours of seeding a night means that it sometimes takes a 4k 5.1 remux like 4 days to download (80GB sometimes). Your scheduler works perfect for this.

The problem that I had was that I wanted an option to ignore the scheduler because if I'm not doing anything on the internet during the day and I want something to download a bit faster than I wanted an option to keep the downloads going regularly, out of the schedule for a short time I can just check a button and the download continues normally.

Once I started digging around in the code, I found that I could disable and re-enable the plugin and all of the settings would stay the same, but I didn't know this until I started messing around with uninstalling, testing, and reinstalling the plugins. For the end-user, it makes more sense to me to give an option for that so they don't have to go through the hassle of disabling, re-enabling and testing if their settings are the same.

I would love to add on to this and create a timer function for the ignore scheduler that lets you set what time you want to turn the scheduler back on...

These are just some ideas I had. Let me know what you think.

h3llrais3r commented 5 years ago

@akennedy4155 Thanks for explaining the use case. It makes indeed sense to be able to quickly toggle the schedule on/off.

If you confirm that my branch is working as expected, I'll release it asap as a new version. For adding the time, I propose that you create a new issue explaining the usage and I'll mark it as feature request. I'll then have a look if I can easily provide this feature.

h3llrais3r commented 5 years ago

Closed in favor of #9

h3llrais3r commented 5 years ago

Released as version 0.3.7.