search

h3poteto / megalodon-rs

Fediverse API client library for Rust
Apache License 2.0
106 stars 24 forks source link

Allow Pleroma statuses to have quotes #244

Closed nullishamy closed 1 month ago

nullishamy commented 1 month ago

If I'm not mistaken, Pleroma should support quoting and thus we should include the parameter when sending the request. quote_id is ignored currently.

h3poteto commented 1 month ago

Really? Which pleroma instance are you using?

nullishamy commented 1 month ago

Really? Which pleroma instance are you using?

https://labyrinth.zone @h3poteto. I inspected the requests from my web ui, and it is the same structure, just with quote_id set. Megalodon does not set that field currently, which means it won't get processed as a quote.

h3poteto commented 1 month ago

This instance is Akkoma, not Pleroma. And probably Pleroma doesn't support quote yet.

nullishamy commented 1 month ago

Oh, my mistake. I thought it was running a Pleroma backend. No problem. One thing I did notice is that quotes also don't get forwarded through megalodon properly. the quote bool doesn't seem to be accurate, and in the case of quotes being present, the reblog field was not populated with the quoted post. Would it be possible to make this checking better as to support the retrieval of quotes at least?

h3poteto commented 1 month ago

Since Pleroma doesn't support quoting, it is natural that the quote flag is not reflected correctly. This behavior is developed for Firefish, so you may improve it as long as it doesn't break the consistency with other SNS.

nullishamy commented 1 month ago

Alright, makes sense. I can maybe look into adding akkoma specific stuff so that it will render on Pleroma compatible APIs that do support quoting. Will close this one out for now and open another PR in the future for the mentioned functionality.