firefish getStatusContext: add ancestors by calling notes/conversation - Githubissues

h3poteto / megalodon

Fediverse API client library for node.js and browser

https://h3poteto.github.io/megalodon/

MIT License

250 stars 33 forks source link

firefish getStatusContext: add ancestors by calling notes/conversation #2225

Closed sftblw closed 3 weeks ago

sftblw commented 3 weeks ago

getStatusContext should return ancestors but firefish does not return them with notes/chilren.
notes/conversation does provide ancestors but It requires another call.
calling different api twice can be controversy about dealing options - possibly duplicating result count, but better than no ancestors at all imo.

tested on my iceshrimp instance; v2023.12.9 with megalodon firefish setup
firefish also have notes/conversation api
/api/notes/conversation returns ancestor in reverse order, so added .reverse() at the end.

I know this introduces unexpected behavior, so I don't mind just closing it.