search

h4110w33n / coinmetrics

An unofficial Python module for interacting with the Coin Metrics (coinmetrics.io) API.
6 stars 5 forks source link

ProAPI Buildout #24

Open h4110w33n opened 4 years ago

h4110w33n commented 4 years ago

It is about time to build this out. I will prototype all the methods; however, since I still lack an API key at the time of committing this, I can only perform basic smoke tests.

I will be reaching out to the Coinmetrics team to see if we can work something out.

pep8speaks commented 4 years ago

Hello @h4110w33n! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 14:1: E302 expected 2 blank lines, found 1

Line 8:1: E302 expected 2 blank lines, found 1

Line 7:1: E302 expected 2 blank lines, found 1 Line 14:101: E501 line too long (161 > 100 characters)

Line 11:1: E302 expected 2 blank lines, found 1 Line 34:1: E302 expected 2 blank lines, found 1 Line 48:1: E302 expected 2 blank lines, found 1

Line 17:1: E402 module level import not at top of file Line 55:34: W292 no newline at end of file

codecov-commenter commented 4 years ago

Codecov Report

Merging #24 into master will decrease coverage by 0.90%. The diff coverage is 60.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##            master      #24      +/-   ##
===========================================
- Coverage   100.00%   99.09%   -0.91%     
===========================================
  Files            6        7       +1     
  Lines          651      661      +10     
===========================================
+ Hits           651      655       +4     
- Misses           0        6       +6
Impacted Files Coverage Δ
coinmetrics/pro.py 40.00% <40.00%> (ø)
coinmetrics/__init__.py 100.00% <100.00%> (ø)
coinmetrics/base.py 100.00% <100.00%> (ø)
coinmetrics/community.py 100.00% <100.00%> (ø)
coinmetrics/utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e1e72d8...359ec14. Read the comment docs.