search

h4110w33n / coinmetrics

An unofficial Python module for interacting with the Coin Metrics (coinmetrics.io) API.
6 stars 5 forks source link

Rewrite needed for the v4 API underway #29

Open h4110w33n opened 2 years ago

h4110w33n commented 2 years ago

The Coinmetrics v4 API diverges pretty far from the 2/3.x APIs that this module was initially written for. I've also been meaning to get some housecleaning figures out, so I'm taking this as an opportunity to get that all done.

Below is what I plan to accomplish here:

  1. Rewrite so that we work with v4 API.
  2. Update the docs/ to
  3. Update tests and linting processes
  4. Migrate from TravisCI to GitHub Actions.
  5. (Optional) Setup auto push to PyPI when things are merged to master.

These changes inbound are going to be pretty big, and will require work on your part to reintegrate into your workflow. I'll include pandas helpers which hopefully covers the majority of use cases.

pep8speaks commented 2 years ago

Hello @h4110w33n! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 12:1: E302 expected 2 blank lines, found 1

Line 90:101: E501 line too long (106 > 100 characters) Line 110:26: W292 no newline at end of file Line 110:26: W292 no newline at end of file Line 110:26: W292 no newline at end of file

Line 17:1: E402 module level import not at top of file Line 55:34: W292 no newline at end of file

Comment last updated at 2022-01-30 20:49:04 UTC
codecov-commenter commented 2 years ago

Codecov Report

Merging #29 (08084fb) into master (1eb397c) will decrease coverage by 16.96%. The diff coverage is 74.32%.

:exclamation: Current head 08084fb differs from pull request most recent head 7787e0b. Consider uploading reports for the commit 7787e0b to get more accurate results Impacted file tree graph

@@             Coverage Diff              @@
##            master      #29       +/-   ##
============================================
- Coverage   100.00%   83.03%   -16.97%     
============================================
  Files            6        4        -2     
  Lines          651      112      -539     
============================================
- Hits           651       93      -558     
- Misses           0       19       +19
Impacted Files Coverage Δ
coinmetrics/catalog.py 51.35% <51.35%> (ø)
coinmetrics/base.py 96.00% <80.00%> (-4.00%) :arrow_down:
coinmetrics/__init__.py 100.00% <100.00%> (ø)
test.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1eb397c...7787e0b. Read the comment docs.