search

h4570 / tyra

Game engine for PlayStation 2™
Apache License 2.0
487 stars 37 forks source link

Fixed writeLogsToFile #161

Closed GDQR closed 11 months ago

GDQR commented 11 months ago

The log file works on the emulator but it didn't work on real hardware.

I managed to fix it by changing the smart pointer for a file that opens and closes in the same function. Now it works on emulator and on real hardware.

I tried to make the file open only once and that it can be used many times, just like with the smart pointer, but I couldn't get it to work in the emulator and on a real PS2 at the same time.

Additional Information: Tested on a PCSX2 1.6.0 emulator edit: PS2 model 90001 Ulaunchelf 4.43x_isr (mod by israpps) edit: USB 3.2 DataTraveler Exodia 16GB FAT32

Deleted logFile smart pointer and getLogFile function. logfile created inside of the statics functions.

Wolf3s commented 11 months ago

Suggestion: put this same code that you write, inside of debug.cpp

GDQR commented 11 months ago

alright now i do it

Wolf3s commented 11 months ago

alright now i do it

Thanks i aprroved your changes sounds more portable

h4570 commented 11 months ago

Thanks!