search

h4cc / AliceFixturesBundle

A Symfony2 bundle for using Alice and Faker with data fixtures. Abled to use Doctrine ORM as well as Doctrine MongoDB ODM.
MIT License
75 stars 25 forks source link

Add feature to create many managers #16

Closed mcg-web closed 10 years ago

h4cc commented 10 years ago

Thank you very much for that contribution, its looking great!

Made some comments in the changed files, please have a look on that. I see the ConfigurationTest.php is missing. Whats the cause?

Support for Doctrine 2.1 has been raised to minimum 2.2. Would there be a way to avoid that?

mcg-web commented 10 years ago

hi, I removed ConfigurationTest.php because now we are using a prototype to define the manager configuration values! We can't test the default config values directly(not 100% sure) but anyway the configuration is test in extension test file. I fixed the doctrine min version but having an issue with mongo-ext on travis.

h4cc commented 10 years ago

As far as i can see, its not travis that is failing, its scrutinizer. As long as travis is running, its fine. Scrutinizer executes the tests also, i will configure that different.

You can remove that services: mongodb from travis.yml

h4cc commented 10 years ago

Your contribution looks great!

When you think its ready, it would be cool to have a squashed commit for your pull request, please.

mcg-web commented 10 years ago

I squashed commit and remove "services: mongodb" from travis, it is now ready to be merge :)

h4cc commented 10 years ago

Thanks!