search

h4cc / AliceFixturesBundle

A Symfony2 bundle for using Alice and Faker with data fixtures. Abled to use Doctrine ORM as well as Doctrine MongoDB ODM.
MIT License
75 stars 25 forks source link

Use nelmio/alice's newer version #50

Open utkuaydin opened 9 years ago

utkuaydin commented 9 years ago

If it isn't breaking anything, AliceFixturesBundle could require Alice's new 2.0 version instead of 1.6.

utkuaydin commented 9 years ago

It breaks some stuff apparently. I'll try to make it work.

utkuaydin commented 9 years ago

I modified Factory so it uses Alice's new Loader. However a problem occurs while loading FixtureSets and that problem is fixed by nelmio/alice@5202ac9. But that fix isn't a part of 2.0.0 release so we will either wait for a new Alice release or require its master branch until there is a new release.

(phpunit tests were running fine for me, Travis gave this error about package signatures and Scrutinizer gave a phpcs: not found error)

theofidry commented 9 years ago

Checkout hautelook/AliceBundle#58!

utkuaydin commented 9 years ago

@theofidry I will, thanks. I am disappointed to see my PR getting no attention for a month.

theofidry commented 9 years ago

Don't blame the guy, @h4cc may no longer have time to maintain this bundle. But he should add a note a deprecate its package though.

utkuaydin commented 9 years ago

@theofidry Don't get me wrong, I am thankful for the bundle. He may no longer have the time or the desire to maintain it and that's absolutely fine. Letting me know that he can't merge would be a nice gesture (and that counts as attention, IMHO) but I can live without it. :smile:

h4cc commented 9 years ago

I would like to blame my job and our customers ... :sob:

Will try to have a look as soon as there is spare time. :clock1:

utkuaydin commented 9 years ago

:smile: That's great, thanks!

theofidry commented 9 years ago

Haha now you can also merge back your work to hautelook/AliceBundle ;)

h4cc commented 9 years ago

@theofidry I will have a look then :)

Trivia: 2 years after my initial question https://github.com/hautelook/AliceBundle/issues/7

theofidry commented 9 years ago

Yes, although not as much as I would like.

The dependency to DoctrineFixturesBundle has been completely removed although you can use both of them together. For more information on this: DoctrineFixturesBundle support.

But I'm still using doctrine/data-fixtures and I don't think that will change for the use cases with Doctrine. I would like to check the support with Doctrine ODM and add a support for Propel too. So there's still some work left on this side.

munkie commented 9 years ago

Hi, @h4cc Are there any chances of merging this PR and releasing new version of alice-bundle? It could be 1.0.x branch for example. And you could use 2.0.x-dev version of nelmio/alice bundle And php minimum version should be set to 5.4 as in nelmio/alice.

theofidry commented 9 years ago

Curious to have you though on this @h4cc. If you plan to upgrade this bundle it's fine otherwise it would be better to note this project as deprecated (and on composer too). Did you have the time to check HautelookAliceBundle?

theofidry commented 8 years ago

Update on the issue @h4cc: HautelookAliceBundle has been out and stable for some time already now, so this library could be deprecated in favour of it.

I do think there's still a lot that could be done, but IMO they require deeper changes that must addressed at https://github.com/nelmio/alice level, in which case people can make it happen for alice v3.