search

h4cc / hhvm-progress

Source of the hhvm.h4cc.de website.
http://hhvm.h4cc.de/
MIT License
8 stars 4 forks source link

Differentiate correctly beetween hhvm and hhvm-nightly #41

Closed h4cc closed 9 years ago

h4cc commented 10 years ago

Seems to be a bug:

http://hhvm.h4cc.de/package/yiisoft/yii2-dev https://github.com/yiisoft/yii2/blob/master/.travis.yml#L7

Source: https://twitter.com/cebe_cc/status/518352932891557888

stof commented 10 years ago

I was about to report the same for http://hhvm.h4cc.de/package/doctrine/instantiator, which should be marked as fully tested given that it does not allow failures on HHVM stable

njasm commented 10 years ago

Exactly the same problem on https://github.com/njasm/container , .travis.yml allows failure on hhvm-nightly but not on hhvm, and the project is still marked as Partially tested.

njasm commented 10 years ago

src/h4cc/HHVMProgressBundle/Services/TravisFetcher.php is buggy.. does not differentiate from hhvm and hhvm-nightly when both versions are set to test against, and one is allowed-failure.

@h4cc are you accepting pull request from the community on your project? if so, I can fork and provide some fix..

h4cc commented 10 years ago

@njasm Yes, Fork and Pull is welcome :)

njasm commented 10 years ago

how do we wanna tackle this?

If a project is building hhvm and hhvm-nightly, and allows to fail ONLY ONE version of hhvm (doesn't care if nightly or not - project owner have is own reasons for that) and not the other, should the result be TESTED ?

h4cc commented 10 years ago

I think it should be as you described @njasm. If there is at least one of hhvm or hhvm-nightly that are not a allowed failure, it should be TESTED.

njasm commented 10 years ago

here it it.. feel free to review it..

h4cc commented 9 years ago

Deployed, thanks!

njasm commented 9 years ago

no problem mate. my pleasure!

stof commented 9 years ago

@h4cc You should force updating all packages in your DB, so that existing versions are updated to reflect this fix. For instance, doctrine/common dev-master is actually not allowing failures on HHVM stable anymore, but http://hhvm.h4cc.de/package/doctrine/common does not reflect it